fix: eliminate circular dependency index.ts-> parsing.ts-> index.ts#44
Draft
DavidSanwald wants to merge 1 commit intoDeepLcom:mainfrom
Draft
fix: eliminate circular dependency index.ts-> parsing.ts-> index.ts#44DavidSanwald wants to merge 1 commit intoDeepLcom:mainfrom
DavidSanwald wants to merge 1 commit intoDeepLcom:mainfrom
Conversation
Author
|
it could be the case, that the types in index.ts were intended to be part of the public module surface. I didn't check yet, therefore it's currently still a draft. |
types in index.ts have been moved to types.ts, a function defined in index.ts has been moved to parsting.ts, next to its use
DavidSanwald
force-pushed
the
fix/resolve-circular-dependencies
branch
from
aba565c to
aca17dd
Compare
Author
|
Ah, now I see the JSDoc strings. But can could it be that the case, that the module API exposes a lot of things, that wouldn't need to be public? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types in index.ts have been moved to types.ts, a function defined in index.ts has been moved to parsting.ts, next to its use
fixes
#43